Timeout handling #22
Closed
Timeout handling #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsudaar
reviewed
Jun 30, 2020
| def self.timeout(client) | ||
| new( | ||
| client: client, | ||
| status: nil, |
There was a problem hiding this comment.
Should we add another status for timeout ? There might be other reason for an empty status (DNS resolution failed, connection reset, etc...)
|
Closing for now. Not sure this is the right way to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21
Changes an internal API,
unpack. The response is now supplied as the return value of a block in order to catch exceptions. Current use case is handling timeout responses.First commits switches to the new version of
unpack, second leverages it to handle timeouts.